Fix point in time toXContent impl #62080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointInTimeBuilder is a ToXContentObject yet it does not print out a whole object (it is rather a fragment). Also, when it is printed out as part of SearchSourceBuilder, an error is thrown because pit should be wrapped into its own object. This commit fixes this and adds tests for it.
javanna
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
approved these changes
Sep 8, 2020
|
thanks @mayya-sharipova ! |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 8, 2020
testShouldMinimizeRoundtrips creates a random search request, though some parts of the request can't be randomized or they will affect what shouldMinimizeRoundtrips returns. We just introduced randomizing the point in time builder (elastic#62080) which is causing failures as roundtrips cannot be minimized when pit is used.
dnhatn
added a commit
that referenced
this pull request
Sep 8, 2020
Search with point in time does not support ccs_minimize_round_trips Relates #62080
dnhatn
added a commit
that referenced
this pull request
Sep 8, 2020
dnhatn
pushed a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 10, 2020
PointInTimeBuilder is a ToXContentObject yet it does not print out a whole object (it is rather a fragment). Also, when it is printed out as part of SearchSourceBuilder, an error is thrown because pit should be wrapped into its own object. This commit fixes this and adds tests for it.
dnhatn
pushed a commit
that referenced
this pull request
Sep 10, 2020
PointInTimeBuilder is a ToXContentObject yet it does not print out a whole object (it is rather a fragment). Also, when it is printed out as part of SearchSourceBuilder, an error is thrown because pit should be wrapped into its own object. This commit fixes this and adds tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointInTimeBuilder is a ToXContentObject yet it does not print out a whole object (it is rather a fragment). Also, when it is printed out as part of SearchSourceBuilder, an error is thrown because pit should be wrapped into its own object.
This commit fixes this and adds tests for it.
Relates to #61062