Log bulk errors when indexing deprecation logs #62159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk processor used to index deprecation logs was doing nothing to output any errors encountered when writing documents to ES. These are now detected. Also expand the deprecation REST tests to check the shape of the indexed documents.
pugnascotia
added
>non-issue
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
pgomulka
approved these changes
Sep 9, 2020
Contributor
pgomulka
left a comment
pgomulka
left a comment
There was a problem hiding this comment.
LGTM - left minor comment
| logger.trace( | ||
| "indexed [{}] deprecation documents into [{}]", | ||
| numberOfActions, | ||
| Arrays.stream(response.getItems()).map(BulkItemResponse::getIndex).distinct().collect(Collectors.joining(",")) |
Contributor
There was a problem hiding this comment.
nit: we could use
logger.trace(
"indexed [{}] deprecation documents into [{}]",
request::numberOfActions,
()-> Arrays.stream(response.getItems()).map(BulkItemResponse::getIndex).distinct().collect(Collectors.joining(","))
passing parameters suppliers instead of guarding with logger.isTraceEnabled()
I understand that this pattern is common though - we probably don't have a elasticsearch wide convention for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk processor used to index deprecation logs was doing nothing to
output any errors encountered when writing documents to ES. These are
now detected.
Also expand the deprecation REST tests to check the shape of the indexed
documents.
This is a partial forward-port from #61966, so no backport is required.