-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the 'fields' option in inner_hits and top_hits. #62259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example mapping and search request.
Note that the full path to the field must be specified ( |
jtibshirani
force-pushed
the
fields-inner-hits
branch
from
September 10, 2020 22:33
21aff68
to
3e49a00
Compare
jtibshirani
force-pushed
the
fields-inner-hits
branch
from
September 10, 2020 22:42
3e49a00
to
ce161fb
Compare
jtibshirani
added
:Search/Search
Search-related issues that do not fall into other categories
>enhancement
v7.10.0
v8.0.0
labels
Sep 10, 2020
Pinging @elastic/es-search (:Search/Search) |
jtibshirani
force-pushed
the
fields-inner-hits
branch
from
September 11, 2020 00:19
c62e7d8
to
1b9db99
Compare
jtibshirani
force-pushed
the
fields-inner-hits
branch
from
September 11, 2020 01:09
1b9db99
to
53d6c58
Compare
jimczi
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
server/src/main/java/org/elasticsearch/index/query/InnerHitBuilder.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/search/aggregations/metrics/TopHitsAggregationBuilder.java
Outdated
Show resolved
Hide resolved
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Sep 14, 2020
This PR adds support for the 'fields' option in the following places: * Anytime `inner_hits` is used, for both fetching nested/ child docs and field collapsing * The `top_hits` aggregation Addresses elastic#61949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the 'fields' option in the following places:
inner_hits
is used, for both fetching nested/ child docs and field collapsingtop_hits
aggregationAddresses #61949.