add country_name to the default properties of geoip ingest processor #62915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine ok to test |
jrodewig
added
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management
danhermann
suggested changes
Sep 29, 2020
There was a problem hiding this comment.
@gaobinlong, thanks for adding this. I think the source of the current test failures is that country_name needs to be added to the results of the query in the geoip.asciidoc file around line 280. If you can add that, I think we can get this merged.
|
@danhermann, thanks for your review, I have done that and all checks have paased yet. |
|
Thanks, @gaobinlong! I've merged this in. |
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 1, 2020
danhermann
added a commit
that referenced
this pull request
Oct 1, 2020
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 1, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated.
3 tasks
andrewkroh
added a commit
to elastic/beats
that referenced
this pull request
Oct 2, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated.
2 tasks
3 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 7, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated. (cherry picked from commit 13a5463)
andrewkroh
added a commit
to elastic/beats
that referenced
this pull request
Oct 7, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated. (cherry picked from commit 13a5463)
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 7, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated. (cherry picked from commit 13a5463)
3 tasks
andrewkroh
added a commit
to elastic/beats
that referenced
this pull request
Oct 8, 2020
Elasticsearch added country_name to the list of default field for geo in elastic/elasticsearch#62915. So the expected files needed updated. (cherry picked from commit 13a5463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61523.
The main changes are:
coutry_nameto the default properties of geoip processor.