Don't emit separate warnings for type filters #63391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>non-issue
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Contributor
Author
|
Marked as |
imotov
approved these changes
Oct 7, 2020
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
LGTM. Thank you for a quick turn around!
romseygeek
added a commit
that referenced
this pull request
Oct 7, 2020
#63214 made TypeFieldType a constant field, and fixed things so that it always emits deprecation warnings whenever it is referenced in a query or aggregation. However, it also emits warnings when it is used to build a type filter through the search context; this is unnecessary, as warnings are already emitted by the REST layer when types are specified as part of the URL, and it is causing failures in some BWC tests. This commit adds a specialised typeFilter method to TypeFieldType to handle this case without emitted any extra warnings. It also removes an unused duplicate TypeFieldType class that resulted from a backport merge error. Fixes #63366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63214 made TypeFieldType a constant field, and fixed things so that it always
emits deprecation warnings whenever it is referenced in a query or aggregation.
However, it also emits warnings when it is used to build a type filter through
the search context; this is unnecessary, as warnings are already emitted by
the REST layer when types are specified as part of the URL, and it is causing
failures in some BWC tests.
This commit adds a specialised
typeFiltermethod to TypeFieldType to handlethis case without emitted any extra warnings. It also removes an unused duplicate
TypeFieldType class that resulted from a backport merge error.
Fixes #63366