[Docs] Correct default scroll_size for update by query #63656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
elasticmachine
added
Team:Distributed (Obsolete)
Member
Author
|
@dnhatn thanks |
cbuescher
pushed a commit
that referenced
this pull request
Oct 14, 2020
The current _update_by_query documentation mentions a scroll_size default of 100 and later another default of 1000. We use the default of 1000 defined in AbstractBulkByScrollRequest and this PR changes the documentation accordingly. Closes #63637
cbuescher
pushed a commit
that referenced
this pull request
Oct 14, 2020
The current _update_by_query documentation mentions a scroll_size default of 100 and later another default of 1000. We use the default of 1000 defined in AbstractBulkByScrollRequest and this PR changes the documentation accordingly. Closes #63637
cbuescher
pushed a commit
that referenced
this pull request
Oct 14, 2020
The current _update_by_query documentation mentions a scroll_size default of 100 and later another default of 1000. We use the default of 1000 defined in AbstractBulkByScrollRequest and this PR changes the documentation accordingly. Closes #63637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current _update_by_query documentation mentions a
scroll_sizedefault of 100 and later another default of 1000.I believe we use the default of 1000 defined in AbstractBulkByScrollRequest here and changed the documentation
accordingly.
This should also be used by "_delete_by_query" and the change in the common parameter doc should also reflect that already.
Closes #63637