Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value_count mode to rate agg #63687

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Oct 14, 2020

Adds a new value count mode to the rate aggregation.

Closes #63575

Adds a new value count mode to the rate aggregation.

Closes elastic#63575
@imotov imotov requested a review from not-napoleon October 14, 2020 17:01
@imotov imotov removed the WIP label Oct 14, 2020
@imotov imotov marked this pull request as ready for review October 14, 2020 17:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 14, 2020
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov imotov merged commit e6c70f6 into elastic:master Oct 15, 2020
imotov added a commit that referenced this pull request Oct 19, 2020
Adds a new value count mode to the rate aggregation.

Closes #63575
@imotov imotov deleted the issue-63575-value-count-rate branch November 6, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for value counts to rate aggregation
4 participants