Add view_index_metadata over metricbeat-* for monitoring agent #63750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>bug
:Security/Authorization
|
Pinging @elastic/es-security (:Security/Authorization) |
BigPandaToo
reviewed
Oct 15, 2020
| assertThat(remoteMonitoringAgentRole.runAs().check(randomAlphaOfLengthBetween(1, 12)), is(false)); | ||
|
|
||
| assertThat(remoteMonitoringAgentRole.indices().allowedIndicesMatcher(RecoveryAction.NAME) | ||
| Role remoteMonitoringCollectorRole = Role.builder(roleDescriptor, null).build(); |
There was a problem hiding this comment.
Why did you change it ti remoteMonitoringCollectorRole while the changes are added to remote_monitoring_agent?
There was a problem hiding this comment.
It's mainly a rename see: c89d0e9 .
Besides the rename, because the roles are similar sounding but different in scopee I've tested that only one of them grants the desired privileges.
|
LGTM |
BigPandaToo
approved these changes
Oct 15, 2020
|
Thank you @BigPandaToo ! |
albertzaharovits
added a commit
that referenced
this pull request
Oct 15, 2020
The `remote_monitoring_agent` reserved role is extended to grant more privileges over the metricbeat-* index pattern. In addition to the index and create_index index privileges that it granted already, it now also grants the view_index_metadata privilege. Closes #63203
albertzaharovits
added a commit
that referenced
this pull request
Oct 15, 2020
The `remote_monitoring_agent` reserved role is extended to grant more privileges over the metricbeat-* index pattern. In addition to the index and create_index index privileges that it granted already, it now also grants the view_index_metadata privilege. Closes #63203
|
It will be in 7.10 BC3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remote_monitoring_agentreserved role is extended to grant more privileges over themetricbeat-*index pattern.In addition to the
indexandcreate_indexindex privileges that it granted already, it now also grants theview_index_metadataprivilege.See #63203 for more details.
The
remote_monitoring_collectorrole has not been changed.Reviewers might prefer to look at the ef1eb01 commit for the diff, as the other commit c89d0e9 is a rename that clutters a bit the diff of the whole PR.
Closes #63203