Move indexAnalyzer to FieldTypeLookup #63932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MappingLookup currently holds and exposes a FieldNameAnalyzer. Given that it is built based on the field types and their configured field analyzers, it makes more sense to have as part of FieldTypeLookup. As a follow-up, I plan to make FieldTypeLookup public and expose it directly to QueryShardContext, hence this change helps so that PercolateQueryBuilder no longer needs to go through MappingLookup to retrieve the index analyzer. Also I plan to remove the indexAnalyzer method from MappingLookup.
javanna
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Contributor
|
I think this will be made unnecessary by #63937 which removes the default index analyzer entirely |
Member
Author
|
True, if we move index analyzer to the mappers, they no longer fit into FieldTypeLookup which is about field types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MappingLookup currently holds and exposes a FieldNameAnalyzer. Given that it is built based on the field types and their configured field analyzers, it makes more sense to have as part of FieldTypeLookup.
As a follow-up, I plan to make FieldTypeLookup public and expose it directly to QueryShardContext, hence this change helps so that PercolateQueryBuilder no longer needs to go through MappingLookup to retrieve the index analyzer. Also I plan to remove the indexAnalyzer method from MappingLookup.