Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop boost from runtime distance feature query #63949

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Drop boost from runtime distance feature query #63949

merged 1 commit into from
Oct 21, 2020

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 20, 2020

This drops the boost parameter of the distance_feature query builder
internally, relying on our query building infrastructure to wrap the
query in a boosting query.

Relates to #63767

@nik9000 nik9000 added >bug :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.11.0 labels Oct 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 20, 2020
@nik9000
Drop boost from runtime distance feature query
5c52edd 
This drops the `boost` parameter of the `distance_feature` query builder
internally, relying on our query building infrastructure to wrap the
query in a `boosting` query.

Relates to elastic#63767
mayya-sharipova
mayya-sharipova approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nik9000 Thanks for this, LGTM!

@nik9000 nik9000 merged commit f2bcc77 into elastic:master Oct 21, 2020
@nik9000
Copy link
Member Author

nik9000 commented Oct 21, 2020

Thanks for reviewing @mayya-sharipova !

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 21, 2020
@nik9000
Drop boost from runtime distance feature query (elastic#63949)
3fa9089 
This drops the `boost` parameter of the `distance_feature` query builder
internally, relying on our query building infrastructure to wrap the
query in a `boosting` query.

Relates to elastic#63767
nik9000 added a commit that referenced this pull request Oct 21, 2020
@nik9000
Drop boost from runtime distance feature query (#63949) (#64005)
2c0145a 
This drops the `boost` parameter of the `distance_feature` query builder
internally, relying on our query building infrastructure to wrap the
query in a `boosting` query.

Relates to #63767
@stevejgordon stevejgordon mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

Assignees
No one assigned
Labels
>bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nik9000 @elasticmachine @mayya-sharipova @jakelandis