Move watcher history to data stream #64252
Conversation
This reverts commit 100dba5.
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
|
I mark this as breaking since we change naming convention of watcher history - it no longer contains date in it, there's single data stream (per version) for all records |
|
@probakowski do you mind elaborating with an example of the difference in the response (before, after) so we can better assess if this impacts our UI? cheers! |
There was a problem hiding this comment.
Thanks, @probakowski. Looks pretty good to me. I left one minor comment to address and one minor question.
x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/Watcher.java
Outdated
Show resolved
Hide resolved
| public void flush() { | ||
| bulkProcessor.flush(); | ||
| } |
There was a problem hiding this comment.
Out of curiosity, is this addressing a scenario that's specific to data streams or just a general case where history entries weren't being written?
There was a problem hiding this comment.
Main reason for this is to have clear state after tests. This makes sure that we don't have any pending docs to index so we can do proper cleanup after the test and leave no hanging indices behind
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
|
@elasticmachine run elasticsearch-ci/2 |
|
@sebelga we've changed naming convention here, previously index name contained date it was created (so record created today would go to index |
|
@probakowski was this message for me or @sebgl ? |
|
Tested Watcher UI with these changes and it seems to work as expected. I looked at the code and we're retrieving Watcher history with a search API request aimed at |
Adds an 8.0 breaking change for PR #64252.
This change moves watcher history to data stream.