Support building Iron Bank Docker context #64336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text" This reverts commit 2171b24.
pugnascotia
added
>feature
>non-issue
:Delivery/Packaging
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
mark-vieira
approved these changes
Oct 30, 2020
| @@ -324,6 +362,8 @@ subprojects { Project subProject -> | |||
|
|
|||
| final Architecture architecture = subProject.name.contains('aarch64-') ? Architecture.AARCH64 : Architecture.X64 | |||
| final boolean oss = subProject.name.contains('oss-') | |||
| // We can ignore Iron Bank at the moment as we don't | |||
There was a problem hiding this comment.
Just so I understand, we are effectively not building the iron bank image here becuase we have not added a corresponding "export' project for it, yes?
There was a problem hiding this comment.
Yes, there's no export task, and there won't be without a way to automatically build the image. That would require simulating the Iron Bank image build process.
|
When you have a chance, would you be able to upload a copy of the artifacts generated by the new ironbank target ? As for the "" placeholder, without knowing more what the future automation will look like, i'm ok with this approach. Keeping a blank value "" would be probably easier to standardize, but it's not as explicit as your current value. |
mark-vieira
added
Team:Delivery
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Nov 16, 2020
This PR adds support for building a Docker context for Iron Bank. It doesn't actually build the image - we could add that at a later stage, but this is an attempt to automate at least some of the process. Iron Bank is a lot like our UBI build, except it uses a hardened version of the full UBI image, not the minimal UBI image. They have particular requirements around how the Docker context should be arranged. The Docker build cannot fetch its own artefacts, but instead the context provides a descriptor that locates what is needed for the build. I also added a filter so that after performing expansions on the `Dockerfile`, we squash long runs on newlines together. This makes the output cleaner, while allowing us to break up the unprocessed `Dockerfile` for clarity.
pugnascotia
added a commit
that referenced
this pull request
Nov 16, 2020
Backport of #64336. This PR adds support for building a Docker context for Iron Bank. It doesn't actually build the image - we could add that at a later stage, but this is an attempt to automate at least some of the process. Iron Bank is a lot like our UBI build, except it uses a hardened version of the full UBI image, not the minimal UBI image. They have particular requirements around how the Docker context should be arranged. The Docker build cannot fetch its own artefacts, but instead the context provides a descriptor that locates what is needed for the build. I also added a filter so that after performing expansions on the `Dockerfile`, we squash long runs on newlines together. This makes the output cleaner, while allowing us to break up the unprocessed `Dockerfile` for clarity.
This was referenced Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building a Docker context for Iron Bank. It doesn't actually build the image - we could add that at a later stage, but this is an attempt to automate at least some of the process.
Iron Bank is a lot like our UBI build, except it uses a hardened version of the full UBI image, not the minimal UBI image. They have particular requirements around how the Docker context should be arranged. The Docker build cannot fetch its own artefacts, but instead the context provides a descriptor that locates what is needed for the build.
I also added a filter so that after performing expansions on the
Dockerfile, we squash long runs on newlines together. This makes the output cleaner, while allowing us to break up the unprocessedDockerfilefor clarity.