Fix parsing RareTerms aggregation response failed in RestHighLevelClient #64454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
|
Thanks for your contribution @gaobinlong. Overall it looks pretty good. |
|
Jenkins test this please |
|
@swallez, some test failures here, I have merged the master branch into this branch, can you help to trigger the test again? |
|
Jenkins test this please |
|
@swallez， the test failure may not relate to the code change of this pr? I'm confused about that. https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/12303/testReport/junit/org.elasticsearch.xpack.datastreams/DataStreamRestIT/testDSXpackUsage/ |
|
@elasticmachine update branch |
|
@elasticmachine ok to test |
swallez
pushed a commit
to swallez/elasticsearch
that referenced
this pull request
Nov 16, 2020
…ent (elastic#64454) - Add LongRareTerms and StringRareTerms to the DefaultNamedXContents, ensure that the response of RareTerms aggregation can be parsed correctly. - Add testSearchWithRareTermsAgg method to test the response of RareTerms aggregation can be parsed correctly. - Add some test code to ensure the AggregationsTests can execute successfully.
swallez
added a commit
that referenced
this pull request
Nov 17, 2020
…ent (#65103) Backport of #64454 - Add LongRareTerms and StringRareTerms to the DefaultNamedXContents, ensure that the response of RareTerms aggregation can be parsed correctly. - Add testSearchWithRareTermsAgg method to test the response of RareTerms aggregation can be parsed correctly. - Add some test code to ensure the AggregationsTests can execute successfully. Co-authored-by: bellengao <gbl_long@163.com>
swallez
added a commit
to swallez/elasticsearch
that referenced
this pull request
Nov 17, 2020
…ent (elastic#65103) Backport of elastic#64454 - Add LongRareTerms and StringRareTerms to the DefaultNamedXContents, ensure that the response of RareTerms aggregation can be parsed correctly. - Add testSearchWithRareTermsAgg method to test the response of RareTerms aggregation can be parsed correctly. - Add some test code to ensure the AggregationsTests can execute successfully. Co-authored-by: bellengao <gbl_long@163.com>
swallez
added a commit
that referenced
this pull request
Nov 17, 2020
…5144) Backport of #64454 - Add LongRareTerms and StringRareTerms to the DefaultNamedXContents, ensure that the response of RareTerms aggregation can be parsed correctly. - Add testSearchWithRareTermsAgg method to test the response of RareTerms aggregation can be parsed correctly. - Add some test code to ensure the AggregationsTests can execute successfully. Co-authored-by: bellengao <gbl_long@163.com>
|
Backported to 7.x and 7.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #63025.
The main changes are:
LongRareTermsandStringRareTermsto theDefaultNamedXContents, ensure that the response of RareTerms aggregation can be parsed correctly.testSearchWithRareTermsAggmethod to test the response of RareTerms aggregation can be parsed correctly.AggregationsTestscan execute successfully.