-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove alias with must_exist #65141
Merged
henningandersen
merged 4 commits into
elastic:master
from
henningandersen:fix_remove_alias_with_must_exist
Nov 18, 2020
Merged
Fix remove alias with must_exist #65141
henningandersen
merged 4 commits into
elastic:master
from
henningandersen:fix_remove_alias_with_must_exist
Nov 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <javanna@users.noreply.github.com>
henningandersen
added
>bug
:Data Management/Indices APIs
APIs to create and manage indices and templates
v8.0.0
v7.11.0
labels
Nov 17, 2020
elasticmachine
added
the
Team:Data Management
Meta label for data/management team
label
Nov 17, 2020
Pinging @elastic/es-core-features (Team:Core/Features) |
javanna
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @henningandersen !!
@elasticmachine update branch |
Failure looks similar to #65048 @elasticmachine run elasticsearch-ci/2 |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 18, 2020
Remove alias now parses the must_exist flag and results in a 404 (not found), if the index does not have the alias. Closes elastic#62642 Relates elastic#58100 Co-Authored-By: Luca Cavanna <javanna@users.noreply.github.com>
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 18, 2020
henningandersen
added a commit
that referenced
this pull request
Nov 18, 2020
henningandersen
added a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/Indices APIs
APIs to create and manage indices and templates
Team:Data Management
Meta label for data/management team
v7.11.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove alias now parses the must_exist flag and results in a 404
(not found), if the index does not have the alias.
Closes #62642
Relates #58100
Co-Authored-By: Luca Cavanna javanna@users.noreply.github.com