-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Label legacy rollup APIs #65518
Conversation
|
||
// tag::legacy-rollup-admon[] | ||
WARNING: This documentation is about legacy rollups. Legacy rollups are | ||
deprecated and will be replaced by new rollup functionality introduced in {es} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to add an xref to the updated overview page once that's ready. I've added a note to #65515.
I don't think that's a blocker for this PR tho.
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-docs (Team:Docs) |
@@ -11,6 +29,8 @@ Deletes an existing {rollup-job}. | |||
|
|||
experimental[] | |||
|
|||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused. is the above header also in a second ifndef::permanently-unreleased-branch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I should have explained this better.
There are two conditionals: ifdef
and ifndef
. The content inside ifdef
only displays on the master and 7.x branches (permanently unreleased branches). The content inside ifndef
displays on all other branches.
This lets us use the same source when 7.n is cut from 7.x. Though the source will be the same, 7.x will use the ifdef
content while 7.n will use the ifndef
content.
When we get near release, I'll go through the docs and remove all the conditionals so only the ifdef
content is left. I have a task for that over in #65515.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ok. thanks for the clarification
Changes:
Previews