Be more specific when clearing cache for searchable snapshots shards #66003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks David |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 8, 2020
…6003) Today we evict all cache files that belong to a given searchable snapshot directory when this directory is closed or if the Clear Cache API is used. This eviction iterates over all cache entries and find the entries that matches a given shard. We can be more specific than that by recreating the cache keys to evict from the list of file names instead of iterating over entries.
tlrx
added a commit
that referenced
this pull request
Dec 8, 2020
Today we evict all cache files that belong to a given searchable snapshot directory when this directory is closed or if the Clear Cache API is used. This eviction iterates over all cache entries and find the entries that matches a given shard. We can be more specific than that by recreating the cache keys to evict from the list of file names instead of iterating over entries. Backport of #66003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we evict all cache files that belong to a given searchable snapshot directory when this directory is closed or if the Clear Cache API is used. This eviction iterates over all cache entries and find the entries that matches a given shard. We can be more specific than that by recreating the cache keys to evict from the list of file names instead of iterating over entries.