SQL: Fix SUM(all zeroes) to return 0 instead of NULL (#65796) #66129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the SUM(all zeroes) was `NULL`, but after this change the SUM SQL function call is automatically upgraded into a `stats` aggregation instead of a `sum` aggregation. The `stats` aggregation only results in `NULL` if the there were no rows, no values (all nulls) to aggregate, which is the expected behaviour across different SQL implementations. This is a workaround for the issue elastic#45251 . Once the results of the `sum` aggregation can differentiate between `SUM(all nulls)` and `SUM(all zeroes`) the optimizer rule introduced in this commit needs to be removed. (cherry-picked from b74792a)
palesz
added
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the SUM(all zeroes) was
NULL, but after this change the SUMSQL function call is automatically upgraded into a
statsaggregationinstead of a
sumaggregation. Thestatsaggregation only results inNULLif the there were no rows, no values (all nulls) to aggregate, whichis the expected behaviour across different SQL implementations.
This is a workaround for the issue #45251 . Once the results of the
sumaggregation can differentiate between
SUM(all nulls)andSUM(all zeroes) the optimizer rule introduced in this commit needs to beremoved.
(cherry-picked from b74792a)