Fix SearchableSnapshotsPersistentCacheIntegTests.testCacheSurviveRestart #66354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 17, 2020
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 17, 2020
|
Thanks Henning |
tlrx
added a commit
that referenced
this pull request
Dec 17, 2020
tlrx
added a commit
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
SearchableSnapshotsPersistentCacheIntegTests.testCacheSurviveRestartfails on CI when executing this last verification:This assert verifies that the persistent cache does not contain any cache file documents after the index is deleted. At the time this verification is done, it is possible that the
CacheServicehasn't processed yet the shard deletion notification (inmarkShardAsEvictedInCache) and hasn't evicted yet theCacheFiles associated to the deleted shard (these evictions are executed using anAbstractRunnablein thegenericthread pool).This pull request sets a large cache synchronization interval setting so that no synchronization are likely to be executed in the middle of the test. It also busy-asserts that the persistent cache has deletions (ie, cache files evictions were processed) before synchronization the cache again and checks that there are no more documents in the persistent cache.
Closes #66278