Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] refactor cat transform to show more useful information #66367

Closed

Conversation

hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Dec 15, 2020

Refactoring of cat transform to show more relevant information. The current cat transform shows a lot of configuration details, however cat should show operationally useful information. This PR changes the defaults.

before:

id create_time              version source_index            dest_index pipeline description transform_type frequency max_page_search_size docs_per_second   state
t1 2020-12-15T16:00:37.783Z 7.11.0  kibana_sample_data_logs t1                              batch          1m        500                  -               STOPPED

after:

id   state checkpoint documents_processed checkpoint_progress changes_last_detection_time
t1 started 19         2309                                    Tue Dec 15 17:12:29 CET 2020
t2 stopped 1          13059               100.00              Tue Dec 15 15:21:00 CET 2020
t4 stopped 1          4654569             100.00              Tue Dec 15 15:58:30 CET 2020
t5 stopped 1          4654569             100.00              Tue Dec 15 16:22:25 CET 2020

Todo:

  • document breaking change for 7.12

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Gives a nicer overview of the current state of things at a glance while still allowing users to get specific info if desired.

@hendrikmuhs hendrikmuhs force-pushed the transform-cat-refactor branch 2 times, most recently from b352667 to 1170b65 Compare December 18, 2020 07:26
@hendrikmuhs hendrikmuhs force-pushed the transform-cat-refactor branch from 27fea1a to a525a6f Compare December 21, 2020 07:56
@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs
Copy link
Author

#66718 proposes a new field in stats, if accepted it makes sense to add this field to cat _transforms, therefore this PR is on hold until #66718 got decided

hendrikmuhs pushed a commit that referenced this pull request Jan 20, 2021
transforms reports the the last time changes where detected with changes_last_detected_at, however
that doesn't tell a user it searched for changes, this PR adds a field last_search_time to report
when transform searched for changes the last time.

fixes #66410
relates #66367
hendrikmuhs pushed a commit that referenced this pull request Jan 21, 2021
…67779)

transforms reports the last time changes where detected with changes_last_detected_at, however
that doesn't tell a user it searched for changes, this PR adds a field last_search_time to report
when transform searched for changes the last time.

fixes #66410
relates #66367
backport #66718
@hendrikmuhs
Copy link
Author

replaced by #68232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants