Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix outdated heap references #66646

Merged
merged 5 commits into from
Dec 21, 2020
Merged

[DOCS] Fix outdated heap references #66646

merged 5 commits into from
Dec 21, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Dec 18, 2020 •
edited
Loading

#65905 updated Elasticsearch's default heap settings. #66567 updated the related heap configuration docs.

This PR acts as a follow-up to fix other heap references scattered throughout the docs.

Previews

@jrodewig jrodewig added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Dec 18, 2020
@jrodewig jrodewig requested review from mark-vieira and jasontedor and removed request for mark-vieira December 18, 2020 23:55
@jrodewig jrodewig marked this pull request as ready for review December 18, 2020 23:55
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Dec 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jrodewig jrodewig added the >docs General docs changes label Dec 19, 2020
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Dec 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig requested a review from mark-vieira December 21, 2020 12:58
mark-vieira
mark-vieira approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jrodewig!

docs/reference/how-to/size-your-shards.asciidoc
check the number of shards per node.
consider adding another node.

To check the current size of each node's heap, use the <<cat-nodes,cat nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

@jrodewig
Copy link
Contributor Author

Thanks @mark-vieira!

@jrodewig jrodewig merged commit e9c1cde into elastic:master Dec 21, 2020
@jrodewig jrodewig deleted the docs__clean-up-heap-refs branch December 21, 2020 19:01
This was referenced Dec 21, 2020
Merged
Merged
jrodewig added a commit that referenced this pull request Dec 21, 2020
@jrodewig
[DOCS] Fix outdated heap references (#66646) (#66711)
8021b7d
jrodewig added a commit that referenced this pull request Dec 21, 2020
@jrodewig
[DOCS] Fix outdated heap references (#66646) (#66712)
550e62a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@jasontedor jasontedor Awaiting requested review from jasontedor

Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrodewig @elasticmachine @mark-vieira @jakelandis