Fix test for half-deleted 6x indices import #67587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reenabled and fixed test that verifies that we properly cleanup after 6x leftover data.
henningandersen
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Jan 18, 2021
|
|
||
| writeBrokenMeta(metaStateService -> { | ||
| for (final Path path : paths) { | ||
| try (Stream<Path> stateFiles = Files.list(path.resolve(MetadataStateFormat.STATE_DIR_NAME))) { |
There was a problem hiding this comment.
Think you can just say IOUtils.rm(path.resolve(PersistedClusterStateService.METADATA_DIRECTORY_NAME)); since the MetaStateService#writeGlobalState() will create the directory again. Also preferring PersistedClusterStateService.METADATA_DIRECTORY_NAME over MetadataStateFormat.STATE_DIR_NAME to make it clear that we're wiping the Lucene-based metadata.
There was a problem hiding this comment.
thanks, fixed in f0e72e2
|
@elasticmachine update branch |
henningandersen
added a commit
that referenced
this pull request
Jan 18, 2021
Reenabled and fixed test that verifies that we properly cleanup after 6x leftover data.
henningandersen
added a commit
that referenced
this pull request
Jan 18, 2021
Reenabled and fixed test that verifies that we properly cleanup after 6x leftover data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenabled and fixed test that verifies that we properly cleanup after
6x leftover data.