Skip after restore unreferenced files deletion for searchable snapshots shards #68821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine update branch |
|
Thanks Yannick |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Feb 10, 2021
…s shards (elastic#68821) When a shard is restored from a snapshot there is an after restore step during which files on disk that are not referenced anymore by the restored segments infos file are deleted from disk. The deletion is executed using the Lucene.pruneUnreferencedFiles() method which opens a new IndexWriter and closes it in order to kick off Lucene's internal index files deleter. This step is not necessary for searchable snapshot shards which use the snapshot store type because such shards report a list of files coming from a shard snapshot which never contain unreferenced files. Skipping this step avoids extra unnecessary work when mounting a searchable snapshot index.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Feb 10, 2021
…s shards (elastic#68821) When a shard is restored from a snapshot there is an after restore step during which files on disk that are not referenced anymore by the restored segments infos file are deleted from disk. The deletion is executed using the Lucene.pruneUnreferencedFiles() method which opens a new IndexWriter and closes it in order to kick off Lucene's internal index files deleter. This step is not necessary for searchable snapshot shards which use the snapshot store type because such shards report a list of files coming from a shard snapshot which never contain unreferenced files. Skipping this step avoids extra unnecessary work when mounting a searchable snapshot index.
tlrx
added a commit
that referenced
this pull request
Feb 11, 2021
…s shards (#68821) (#68843) When a shard is restored from a snapshot there is an after restore step during which files on disk that are not referenced anymore by the restored segments infos file are deleted from disk. The deletion is executed using the Lucene.pruneUnreferencedFiles() method which opens a new IndexWriter and closes it in order to kick off Lucene's internal index files deleter. This step is not necessary for searchable snapshot shards which use the snapshot store type because such shards report a list of files coming from a shard snapshot which never contain unreferenced files. Skipping this step avoids extra unnecessary work when mounting a searchable snapshot index.
tlrx
added a commit
that referenced
this pull request
Feb 11, 2021
…s shards (#68821) (#68845) When a shard is restored from a snapshot there is an after restore step during which files on disk that are not referenced anymore by the restored segments infos file are deleted from disk. The deletion is executed using the Lucene.pruneUnreferencedFiles() method which opens a new IndexWriter and closes it in order to kick off Lucene's internal index files deleter. This step is not necessary for searchable snapshot shards which use the snapshot store type because such shards report a list of files coming from a shard snapshot which never contain unreferenced files. Skipping this step avoids extra unnecessary work when mounting a searchable snapshot index.
tlrx
added a commit
that referenced
this pull request
Nov 25, 2021
In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 25, 2021
…c#81047) In elastic#68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (elastic#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 25, 2021
#81051) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 26, 2021
#81050) In #68821 we introduced a condition to skip the pruning of unreferenced files after the restore of a snapshot for searchable snapshot shards. Sadly I managed to mess this up in a refactoring (#75308) few months after. This commit reintroduces the right conditional which is to NOT prune Lucene files for searchable snapshot shards. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a shard is restored from a snapshot there is an after restore step during which files on disk that are not referenced anymore by the restored segments infos file are deleted from disk. The deletion is executed using the
Lucene.pruneUnreferencedFiles()method which opens a newIndexWriterand closes it in order to kick off Lucene's internal index files deleter.This step is not necessary for searchable snapshot shards which use the
snapshotstore type because such shards report a list of files coming from a shard snapshot which never contain unreferenced files. Skipping this step avoids extra unnecessary work when mounting a searchable snapshot index.