ILM: Allow searchable_snapshot to follow searchable_snapshot
#68864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added this validation for the hot phase as that was the only place a searchable_snapshot action could precede another `searchable_snapshot` action. This is not the case anymore and we now support multiple actions in the same policy. This changes the validation to allow the `searchable_snapshot` *in the hot phase* to be followed by other `searchable_snapshot` actions.
andreidan
added
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
andreidan
commented
Feb 10, 2021
| singletonMap(SearchableSnapshotAction.NAME, new SearchableSnapshotAction(snapshotRepo, randomBoolean(), | ||
| MountSearchableSnapshotRequest.Storage.SHARED_CACHE))), | ||
| createPolicy(client(), policy, | ||
| new Phase("hot", TimeValue.ZERO, |
There was a problem hiding this comment.
Piggybacked the hot -> frozen searchable_snapshot actions scenario on this test (as it wasn't tested anywhere)
|
@elasticmachine update branch |
|
This is still a |
dakrone
dismissed
their stale review
I'll wait until this isn't a WIP before approving :)
This expands the validation to include the cases where the frozen action defines illegal actions after a searchable_snapshot defined in the cold phase.
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Feb 15, 2021
…stic#68864) We added this validation for the hot phase as that was the only place a searchable_snapshot action could precede another `searchable_snapshot` action. This is not the case anymore and we now support multiple actions in the same policy. This expands the validation to include the cases where the frozen action defines illegal actions after a searchable_snapshot defined in the cold phase. (cherry picked from commit c10ba9e) Signed-off-by: Andrei Dan <andrei.dan@elastic.co> # Conflicts: # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java
andreidan
added a commit
that referenced
this pull request
Feb 15, 2021
#68864) (#68972) We added this validation for the hot phase as that was the only place a searchable_snapshot action could precede another `searchable_snapshot` action. This is not the case anymore and we now support multiple actions in the same policy. This expands the validation to include the cases where the frozen action defines illegal actions after a searchable_snapshot defined in the cold phase. (cherry picked from commit c10ba9e) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this validation for the hot phase as that was the only place a
searchable_snapshot action could precede another
searchable_snapshotaction.This is not the case anymore and we now support multiple actions in the
same policy.
This changes the validation to allow the
searchable_snapshotin the hotphase to be followed by other
searchable_snapshotactions.