Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove keyword/ip from unsupported fields in top_metrics #69036

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Feb 16, 2021

In #64967, Nik added support for keyword and ip fields for top_metrics. However, the docs for top_metrics still mention keyword and ip fields as not supported. This PR removes those mentions.

I figure it might be good to have some keyword examples as well but I'll leave that up to others and open this PR to at least start the conversation.

@jrodewig jrodewig added :Analytics/Aggregations Aggregations >docs General docs changes v8.0.0 labels Feb 16, 2021
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nik9000
Copy link
Member

nik9000 commented Feb 17, 2021

It turns out that this isn't quite accurate - you still can't sort by keyword or ip. But you can fetch them. We can add sorting support for them if we need it though. I don't think its super complex. But it is more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v7.11.2 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants