Fix Leaking Listener in BlobStoreRepository #69110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have no guarantees that implementations won't throw a non-IO exception in this spot so we have to make sure to resolve the listener on any exception to not leak it.
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| existingListener.onFailure(e); | ||
| }; | ||
| threadPool.generic().execute(() -> doGetRepositoryData( | ||
| threadPool.generic().execute(ActionRunnable.wrap( |
There was a problem hiding this comment.
Not strictly necessary, just for good measure. We do use .wrap in all other calls to doGetRepositoryData as well, just missed it here ...
DaveCTurner
approved these changes
Feb 18, 2021
|
Thanks Francisco and David!
I audited the blob store for this and found one spot that has a TODO on it anyway here: but won't cause trouble in production when asserts are off. I'll open a follow-up to clean up that TODO so that we get clean logging there as well if we run into this problem on a delete. |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 24, 2021
Follow-up to elastic#69110. We can't assume that repository implementations will only throw `IOException`. The GCS SDK for example does throw `StorageException` which is not an IO exception so we must handle all exceptions the same way here.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 24, 2021
We have no guarantees that implementations won't throw a non-IO exception in this spot so we have to make sure to resolve the listener on any exception to not leak it.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 24, 2021
We have no guarantees that implementations won't throw a non-IO exception in this spot so we have to make sure to resolve the listener on any exception to not leak it.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 24, 2021
We have no guarantees that implementations won't throw a non-IO exception in this spot so we have to make sure to resolve the listener on any exception to not leak it.
original-brownbear
added a commit
that referenced
this pull request
Feb 24, 2021
original-brownbear
added a commit
that referenced
this pull request
Feb 24, 2021
original-brownbear
added a commit
that referenced
this pull request
Feb 24, 2021
original-brownbear
added a commit
that referenced
this pull request
Feb 25, 2021
Follow-up to #69110. We can't assume that repository implementations will only throw `IOException`. The GCS SDK for example does throw `StorageException` which is not an IO exception so we must handle all exceptions the same way here.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 25, 2021
Follow-up to elastic#69110. We can't assume that repository implementations will only throw `IOException`. The GCS SDK for example does throw `StorageException` which is not an IO exception so we must handle all exceptions the same way here.
original-brownbear
added a commit
that referenced
this pull request
Feb 25, 2021
Follow-up to #69110. We can't assume that repository implementations will only throw `IOException`. The GCS SDK for example does throw `StorageException` which is not an IO exception so we must handle all exceptions the same way here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no guarantees that implementations won't throw a non-IO exception in this spot
so we have to make sure to resolve the listener on any exception to not leak it.