-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RateLimitingFiltering to plaintext deprecation logs #69190
Add RateLimitingFiltering to plaintext deprecation logs #69190
Conversation
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
Pinging @elastic/es-core-infra (Team:Core/Infra) |
btw @pugnascotia I feel we should try to figure out how do we test against our real log4j2 properties file. JsonLoggerTests are at the moment using a similar file which can get stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this!
…yle_deprecation_logs
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
The #61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs
closes #69188
gradle check
?