Add integration test for Azure multi block uploads #69267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcofdez
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@original-brownbear would you mind reviewing this PR when you have the chance? Thanks! |
original-brownbear
approved these changes
Feb 25, 2021
| final int blobSize = ByteSizeUnit.MB.toIntBytes(2); | ||
| final Executor executor = repo.threadPool().generic(); | ||
| PlainActionFuture<Void> future = PlainActionFuture.newFuture(); | ||
| executor.execute(ActionRunnable.run(future, () -> { |
There was a problem hiding this comment.
NIT: just inline repo.threadPool().generic() here, you're only using executor once
|
@elasticmachine update branch |
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Mar 1, 2021
Relates elastic#68957 Backport of elastic#69267
fcofdez
added a commit
that referenced
this pull request
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #68957