Skip to content

[ML] Reject data frame analytics using runtime fields if not all node… #69331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[ML] Reject data frame analytics using runtime fields if not all node… #69331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...src/main/java/org/elasticsearch/xpack/ml/action/TransportPutDataFrameAnalyticsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.elasticsearch.license.License;
import org.elasticsearch.license.LicenseUtils;
import org.elasticsearch.license.XPackLicenseState;
import org.elasticsearch.search.builder.SearchSourceBuilder;
import org.elasticsearch.tasks.Task;
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.transport.TransportService;
Expand All @@ -39,6 +40,7 @@
import org.elasticsearch.xpack.core.ml.dataframe.DataFrameAnalyticsConfig;
import org.elasticsearch.xpack.core.ml.job.messages.Messages;
import org.elasticsearch.xpack.core.ml.job.persistence.ElasticsearchMappings;
import org.elasticsearch.xpack.core.ml.utils.ExceptionsHelper;
import org.elasticsearch.xpack.core.security.SecurityContext;
import org.elasticsearch.xpack.core.security.action.user.HasPrivilegesAction;
import org.elasticsearch.xpack.core.security.action.user.HasPrivilegesRequest;
Expand Down Expand Up @@ -115,6 +117,21 @@ protected void masterOperation(PutDataFrameAnalyticsAction.Request request, Clus

final DataFrameAnalyticsConfig config = request.getConfig();

// Check if runtime mappings are used but the cluster contains nodes on a version
// before runtime fields were introduced and reject such configs.
if (config.getSource().getRuntimeMappings().isEmpty() == false && state.nodes().getMinNodeVersion().before(Version.V_7_11_0)) {
listener.onFailure(ExceptionsHelper.badRequestException(
"at least one cluster node is on a version [{}] that does not support [{}]; " +
"all nodes should be at least on version [{}] in order to create data frame analytics with [{}]",
state.nodes().getMinNodeVersion(),
SearchSourceBuilder.RUNTIME_MAPPINGS_FIELD.getPreferredName(),
Version.V_7_11_0,
SearchSourceBuilder.RUNTIME_MAPPINGS_FIELD.getPreferredName()
)
);
return;
}

ActionListener<Boolean> sourceDestValidationListener = ActionListener.wrap(
aBoolean -> putValidatedConfig(config, listener),
listener::onFailure
Expand Down