Fix geo_line agg behavior with missing values #69395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The geo_line aggregation incorrectly handled results with missing values. Tests to verify this behavior were incorrectly checking results. This commit resolves these in three ways - explicitely testing missing sort field values - explicitely testing handling missing point field values - explicitely testing handling mixed scenarios where some documents have one and not the other, or missing both. Fixes elastic/kibana#90653. Fixes elastic#69346.
talevy
added
:Analytics/Geo
elasticmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
1 similar comment
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
commented
Feb 23, 2021
...l/src/main/java/org/elasticsearch/xpack/spatial/search/aggregations/GeoLineBucketedSort.java
Show resolved
Hide resolved
nik9000
approved these changes
Feb 23, 2021
...l/src/main/java/org/elasticsearch/xpack/spatial/search/aggregations/GeoLineBucketedSort.java
Show resolved
Hide resolved
talevy
added a commit
that referenced
this pull request
Feb 23, 2021
The geo_line aggregation incorrectly handled results with missing values. Tests to verify this behavior were incorrectly checking results. This commit resolves these in three ways - explicitly testing missing sort field values - explicitly testing handling missing point field values - explicitly testing handling mixed scenarios where some documents have one and not the other, or missing both. Fixes elastic/kibana#90653. Fixes #69346.
talevy
added a commit
that referenced
this pull request
Feb 23, 2021
The geo_line aggregation incorrectly handled results with missing values. Tests to verify this behavior were incorrectly checking results. This commit resolves these in three ways - explicitly testing missing sort field values - explicitly testing handling missing point field values - explicitly testing handling mixed scenarios where some documents have one and not the other, or missing both. Fixes elastic/kibana#90653. Fixes #69346.
|
Hi @talevy, we're encountering what appears to be the issue this PR fixes, and we're running 7.12.1. Was this fix actually applied to 7.12.1? I see the label for 7.12.1 on this issue, but wanted to confirm. |
Contributor
|
@andrewkcarter It looks like it actually made it to 7.12.0 and 7.12.1. I cannot reproduce the issue with reproduction in #69346 in neither. Would you mind sharing more information about the issue that you are seeing, preferably with updated reproduction script that fails in 7.12.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geo_line aggregation incorrectly handled results with missing values. Tests to verify this
behavior were incorrectly checking results. This commit resolves these in three ways
Fixes elastic/kibana#90653.
Fixes #69346.