-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] adding new _preview endpoint for data frame analytics #69453
Merged
benwtrent
merged 9 commits into
elastic:master
from
benwtrent:feature/ml-df-add-_feature_preview-api
Mar 1, 2021
Merged
[ML] adding new _preview endpoint for data frame analytics #69453
benwtrent
merged 9 commits into
elastic:master
from
benwtrent:feature/ml-df-add-_feature_preview-api
Mar 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (Team:ML) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just a comment on reusing the PutDataFrameAnalyticsAction.Request
.
...re/src/main/java/org/elasticsearch/xpack/core/ml/action/PreviewDataFrameAnalyticsAction.java
Show resolved
Hide resolved
docs/reference/ml/df-analytics/apis/preview-dfanalytics.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/api/ml.preview_data_frame_analytics.json
Show resolved
Hide resolved
dimitris-athanasiou
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 1, 2021
…9453) This commit adds a new `_preview` endpoint for data frame analytics. This allows users to see the data on which their model will be trained. This is especially useful in the arrival of custom feature processors. The API design is a similar to datafeed `_preview` and data frame analytics `_explain`. # Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java
benwtrent
added a commit
that referenced
this pull request
Mar 1, 2021
) (#69729) * [ML] adding new _preview endpoint for data frame analytics (#69453) This commit adds a new `_preview` endpoint for data frame analytics. This allows users to see the data on which their model will be trained. This is especially useful in the arrival of custom feature processors. The API design is a similar to datafeed `_preview` and data frame analytics `_explain`.
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
_preview
endpoint for data frame analytics.This allows users to see the data on which their model will be trained. This is especially useful
in the arrival of custom feature processors.
The API design is a similar to datafeed
_preview
and data frame analytics_explain
.