Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transform associated indices #69493

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Feb 23, 2021

These somehow got dropped from the initial Feature States PR, so this
commit adds them again.


Note for reviewers: If you are not familiar with associated indices, they are new as of #63513. See this comment:

/**
* Returns a list of index patterns for "associated indices": indices which depend on this plugin's system indices, but are not
* themselves system indices.
*
* @return A list of index patterns which depend on the contents of this plugin's system indices, but are not themselves system indices
*/

They are currently only used for ensuring all of a feature's indices are included in snapshots that specify they should include that feature's state - that is, if a plugin's system indices are included in a snapshot, that plugin's associated indices will be as well. They will also be used for the upcoming reset API (see #69469).

These somehow got dropped from the initial Feature States PR, so this
commit adds them again.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown gwbrown merged commit bf05ac6 into elastic:master Feb 24, 2021
@gwbrown gwbrown deleted the si/transforms-associated-indices branch February 24, 2021 21:23
gwbrown added a commit to gwbrown/elasticsearch that referenced this pull request Feb 24, 2021
These somehow got dropped from the initial Feature States PR, so this
commit adds them again.
gwbrown added a commit that referenced this pull request Feb 24, 2021
These somehow got dropped from the initial Feature States PR, so this
commit adds them again.
gwbrown added a commit that referenced this pull request Feb 24, 2021
These somehow got dropped from the initial Feature States PR, so this
commit adds them again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants