Script: no compile rate limit for ingest templates #69841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the compilation rate limit for ingest templates. Creates a new context, `ingest_template`, with an unlimited compilation rate limit. The `template` context is used in many places so it cannot be exempted from rate limits. Fixes: elastic#64595
stu-elastic
added
:Core/Infra/Scripting
elasticmachine
added
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Mar 3, 2021
server/src/main/java/org/elasticsearch/script/TemplateScript.java
Outdated
Show resolved
Hide resolved
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Mar 4, 2021
Remove the compilation rate limit for ingest templates. Creates a new context, `ingest_template`, with an unlimited compilation rate limit. The `template` context is used in many places so it cannot be exempted from rate limits. Fixes: elastic#64595 Backport: 9370b1c
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Mar 10, 2021
…lastic#69987) Remove the compilation rate limit for ingest templates. Creates a new context, `ingest_template`, with an unlimited compilation rate limit. The `template` context is used in many places so it cannot be exempted from rate limits. Fixes: elastic#64595 Backport: 9370b1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compilation rate limit for ingest templates.
Creates a new context,
ingest_template, with an unlimitedcompilation rate limit.
The
templatecontext is used in many places so it cannot beexempted from rate limits.
Fixes: #64595