-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid atomic write of large blobs in repo analyzer #69960
Merged
DaveCTurner
merged 4 commits into
elastic:master
from
DaveCTurner:2021-03-04-repo-analyzer-overflow-error
Mar 4, 2021
Merged
Avoid atomic write of large blobs in repo analyzer #69960
DaveCTurner
merged 4 commits into
elastic:master
from
DaveCTurner:2021-03-04-repo-analyzer-overflow-error
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we randomly perform an atomic write even if there are no early reads, but we should only do so if the blob is small enough to write atomically.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.12.0
v7.13.0
labels
Mar 4, 2021
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Mar 4, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
|
fcofdez
reviewed
Mar 4, 2021
...st-kit/src/main/java/org/elasticsearch/repositories/blobstore/testkit/BlobAnalyzeAction.java
Outdated
Show resolved
Hide resolved
fcofdez
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
DaveCTurner
added a commit
that referenced
this pull request
Mar 4, 2021
Today we randomly perform an atomic write even if there are no early reads, but we should only do so if the blob is small enough to write atomically.
DaveCTurner
added a commit
that referenced
this pull request
Mar 4, 2021
Today we randomly perform an atomic write even if there are no early reads, but we should only do so if the blob is small enough to write atomically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.12.0
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we randomly perform an atomic write even if there are no early
reads, but we should only do so if the blob is small enough to write
atomically.