Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid atomic write of large blobs in repo analyzer #69960

Conversation

DaveCTurner
Copy link
Contributor

Today we randomly perform an atomic write even if there are no early
reads, but we should only do so if the blob is small enough to write
atomically.

Today we randomly perform an atomic write even if there are no early
reads, but we should only do so if the blob is small enough to write
atomically.
@DaveCTurner DaveCTurner requested review from fcofdez and ywelsch March 4, 2021 11:35
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Mar 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor Author

>non-issue since this bug never made it into a release.

Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DaveCTurner DaveCTurner merged commit 421df6c into elastic:master Mar 4, 2021
@DaveCTurner DaveCTurner deleted the 2021-03-04-repo-analyzer-overflow-error branch March 4, 2021 16:38
DaveCTurner added a commit that referenced this pull request Mar 4, 2021
Today we randomly perform an atomic write even if there are no early
reads, but we should only do so if the blob is small enough to write
atomically.
DaveCTurner added a commit that referenced this pull request Mar 4, 2021
Today we randomly perform an atomic write even if there are no early
reads, but we should only do so if the blob is small enough to write
atomically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.12.0 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants