Improve ESRestTestCase when running with different node versions. #70361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions don't support component / composable index templates and/or data streams. Yet the test base class tries to remove objects after each test, which adds a significant number of lines to the log files (which slows the tests down). The ESRestTestCase will now check whether all nodes have a specific version and then decide whether data streams and component / composable index templates will be deleted. Also removed old debug log config that was enabled to investigate a build failure (elastic#46091), but has been closed. However the debug logging added many lines log lines to the log files. Relates to elastic#69973
martijnvg
added
>test
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Member
Author
|
Without this change, running locally: Targeted this PR against 7.x, because the mixed clusters qa module times out a lot when running with 6.8.x nodes. This change should be forward ported to master and back ported to 7.12 and 7.11 branches. |
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix |
martijnvg
added
backport
and removed
>test
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 15, 2021
…astic#70361) Backport of the testing related changes from elastic#70314: Older versions don't support component / composable index templates and/or data streams. Yet the test base class tries to remove objects after each test, which adds a significant number of lines to the log files (which slows the tests down). The ESRestTestCase will now check whether all nodes have a specific version and then decide whether data streams and component / composable index templates will be deleted. Also ensured that the logstash-index-template and security-index-template aren't deleted between tests, these templates are builtin templates that ES will install if missing. So if tests remove these templates between tests then ES will add these template back almost immediately. These causes many log lines and a lot of cluster state updates, which slow tests down. Also removed old debug log config that was enabled to investigate a build failure (elastic#46091), but has been closed. However the debug logging added many lines log lines to the log files. Note this change wasn't part of elastic#70314. Relates to elastic#69973
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 15, 2021
…astic#70361) Backport of the testing related changes from elastic#70314: Older versions don't support component / composable index templates and/or data streams. Yet the test base class tries to remove objects after each test, which adds a significant number of lines to the log files (which slows the tests down). The ESRestTestCase will now check whether all nodes have a specific version and then decide whether data streams and component / composable index templates will be deleted. Also ensured that the logstash-index-template and security-index-template aren't deleted between tests, these templates are builtin templates that ES will install if missing. So if tests remove these templates between tests then ES will add these template back almost immediately. These causes many log lines and a lot of cluster state updates, which slow tests down. Also removed old debug log config that was enabled to investigate a build failure (elastic#46091), but has been closed. However the debug logging added many lines log lines to the log files. Note this change wasn't part of elastic#70314. Relates to elastic#69973
martijnvg
added a commit
that referenced
this pull request
Mar 15, 2021
…70364) Backporting #70361 to 7.11 branch. Backport of the testing related changes from #70314: Older versions don't support component / composable index templates and/or data streams. Yet the test base class tries to remove objects after each test, which adds a significant number of lines to the log files (which slows the tests down). The ESRestTestCase will now check whether all nodes have a specific version and then decide whether data streams and component / composable index templates will be deleted. Also ensured that the logstash-index-template and security-index-template aren't deleted between tests, these templates are builtin templates that ES will install if missing. So if tests remove these templates between tests then ES will add these template back almost immediately. These causes many log lines and a lot of cluster state updates, which slow tests down. Also removed old debug log config that was enabled to investigate a build failure (#46091), but has been closed. However the debug logging added many lines log lines to the log files. Note this change wasn't part of #70314. Relates to #69973
martijnvg
added a commit
that referenced
this pull request
Mar 15, 2021
…0363) Backport of #70361 to 7.12 branch. Backport of the testing related changes from #70314: Older versions don't support component / composable index templates and/or data streams. Yet the test base class tries to remove objects after each test, which adds a significant number of lines to the log files (which slows the tests down). The ESRestTestCase will now check whether all nodes have a specific version and then decide whether data streams and component / composable index templates will be deleted. Also ensured that the logstash-index-template and security-index-template aren't deleted between tests, these templates are builtin templates that ES will install if missing. So if tests remove these templates between tests then ES will add these template back almost immediately. These causes many log lines and a lot of cluster state updates, which slow tests down. Also removed old debug log config that was enabled to investigate a build failure (#46091), but has been closed. However the debug logging added many lines log lines to the log files. Note this change wasn't part of #70314. Relates to #69973
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the testing related changes from #70314:
Older versions don't support component / composable index templates
and/or data streams. Yet the test base class tries to remove objects
after each test, which adds a significant number of lines to the
log files (which slows the tests down). The ESRestTestCase will
now check whether all nodes have a specific version and then decide
whether data streams and component / composable index templates will
be deleted.
Also ensured that the
logstash-index-templateandsecurity-index-templatearen't deleted between tests, these templates are builtin templates that
ES will install if missing. So if tests remove these templates between tests
then ES will add these template back almost immediately. These causes
many log lines and a lot of cluster state updates, which slow tests down.
Also removed old debug log config that was enabled to investigate
a build failure (CI failures due to indices not being cleaned up as expected #46091), but has been closed. However the debug logging
added many lines log lines to the log files. Note this change wasn't part
of Support specifying multiple templates names in delete component template api #70314.
Relates to #69973