Improve error message for invalid field name #70972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current error when a field name consists only of path separator dots is not very user friendly. Instead of throwing an array_index_out_of_bounds_exception we can detect this case and throw a more useful IAE. Closes elastic#70960
cbuescher
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Member
Author
|
@javanna thanks for the thumbs up, merging |
cbuescher
pushed a commit
that referenced
this pull request
Mar 29, 2021
The current error when a field name consists only of path separator dots is not very user friendly. Instead of throwing an array_index_out_of_bounds_exception we can detect this case and throw a more useful IAE. Closes #70960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error when a field name consists only of path separator dots is not
very user friendly. Instead of throwing an array_index_out_of_bounds_exception
we can detect this case and throw a more useful IAE.
Closes #70960