-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test module to simulate errors and warnings in search requests #71674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a test module called `error-query` that exposes a query builder to simulate errors and warnings on shard search request. The query accepts a list of indices and shard ids where errors or warnings should be reported: ``` POST test*/_search { "query": { "error_query": { "indices": [ { "name": "test_exception", "shard_ids": [1], "error_type": "exception", "message": "boom" }, { "name": "test_warn*", "error_type": "warning", "message": "Watch out!" } ] } } } ``` The `error_type` can be set to `exception` or `warning` and the `name` accepts simple patterns, aliases and fully qualified index name if the search targets remote shards. This module is published only within snapshots like the other test modules. Relates elastic#70784
jimczi
added
>test
Issues or PRs that are addressing/adding tests
:Search/Search
Search-related issues that do not fall into other categories
v8.0.0
v7.13.0
labels
Apr 14, 2021
Pinging @elastic/es-search (Team:Search) |
\cc @stacey-gammon |
cbuescher
approved these changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
May 6, 2021
…lastic#71674) This change adds a test module called `error-query` that exposes a query builder to simulate errors and warnings on shard search request. The query accepts a list of indices and shard ids where errors or warnings should be reported: ``` POST test*/_search { "query": { "error_query": { "indices": [ { "name": "test_exception", "shard_ids": [1], "error_type": "exception", "message": "boom" }, { "name": "test_warn*", "error_type": "warning", "message": "Watch out!" } ] } } } ``` The `error_type` can be set to `exception` or `warning` and the `name` accepts simple patterns, aliases and fully qualified index name if the search targets remote shards. This module is published only within snapshots like the other test modules. Relates elastic#70784
jimczi
added a commit
that referenced
this pull request
May 6, 2021
…71674) (#72793) This change adds a test module called `error-query` that exposes a query builder to simulate errors and warnings on shard search request. The query accepts a list of indices and shard ids where errors or warnings should be reported: ``` POST test*/_search { "query": { "error_query": { "indices": [ { "name": "test_exception", "shard_ids": [1], "error_type": "exception", "message": "boom" }, { "name": "test_warn*", "error_type": "warning", "message": "Watch out!" } ] } } } ``` The `error_type` can be set to `exception` or `warning` and the `name` accepts simple patterns, aliases and fully qualified index name if the search targets remote shards. This module is published only within snapshots like the other test modules. Relates #70784
This was referenced May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
>test
Issues or PRs that are addressing/adding tests
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a test module called
error-query
that exposes aquery builder to simulate errors and warnings on shard search request.
The query accepts a list of indices and shard ids where errors or warnings
should be reported:
The
error_type
can be set toexception
orwarning
and thename
acceptssimple patterns, aliases and fully qualified index name if the search targets remote shards.
This module is published only within snapshots like the other test modules.
Relates #70784