Fix minimum_should_match for combined_fields query
#72152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `minimum_should_match` parameter for queries like `match` or `query_string" accepts either string values like "2" or "25%", numeric values and in most older cases also `null` as a no-op parameter. We also use examples for these different values in our documentation, so we should also support these value types for the new `combined_fields` query. This changes the ConstructingObjectParser used in CombinedFieldsQueryBuilder so it also accepts integer value types and adds a parsing test for the different cases. Closes elastic#72148
cbuescher
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
jtibshirani
approved these changes
Apr 23, 2021
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks @cbuescher for addressing this! It's a little surprising we accept numbers (since the query builders require a string), but I agree this is worth fixing for consistency.
cbuescher
pushed a commit
that referenced
this pull request
Apr 26, 2021
The `minimum_should_match` parameter for queries like `match` or `query_string" accepts either string values like "2" or "25%", numeric values and in most older cases also `null` as a no-op parameter. We also use examples for these different values in our documentation, so we should also support these value types for the new `combined_fields` query. This changes the ConstructingObjectParser used in CombinedFieldsQueryBuilder so it also accepts integer value types and adds a parsing test for the different cases. Closes #72148
cbuescher
pushed a commit
that referenced
this pull request
Apr 26, 2021
The `minimum_should_match` parameter for queries like `match` or `query_string" accepts either string values like "2" or "25%", numeric values and in most older cases also `null` as a no-op parameter. We also use examples for these different values in our documentation, so we should also support these value types for the new `combined_fields` query. This changes the ConstructingObjectParser used in CombinedFieldsQueryBuilder so it also accepts integer value types and adds a parsing test for the different cases. Closes #72148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
minimum_should_matchparameter for queries likematchorquery_string" accepts either string values like "2" or "25%", numeric values and in most older cases alsonullas a no-op parameter. We also use examples for these different values in our documentation, so we should also support these value types for the newcombined_fields` query. This changes the ConstructingObjectParser used inCombinedFieldsQueryBuilder so it also accepts integer value types and adds a
parsing test for the different cases.
Closes #72148