Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST Compatible API] transformations for keys in do #72823

Merged
merged 9 commits into from
May 14, 2021

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented May 6, 2021

Follow up to #70337 that removes the yml tests it added in favor of rewriting the 7.x tests (in the model of #72156).

@joegallo joegallo added >test Issues or PRs that are addressing/adding tests v8.0.0 labels May 6, 2021
@joegallo joegallo requested a review from jakelandis May 6, 2021 18:20
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick on the naming.

@jakelandis jakelandis added the :Delivery/Build Build or test infrastructure label May 10, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label May 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@joegallo joegallo merged commit 34ab0c0 into elastic:master May 14, 2021
@joegallo joegallo deleted the replace-key-in-do branch May 14, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants