Skip to content

Conversation

@zethsqx
Copy link
Contributor

@zethsqx zethsqx commented Jun 1, 2021

Missing comma in example

Missing comma in example
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 1, 2021
@zethsqx zethsqx changed the title Update set.asciidoc Update set.asciidoc, missing comma in example Jun 1, 2021
@zethsqx zethsqx merged commit ab788be into 7.13 Jun 1, 2021
@zethsqx zethsqx deleted the zethsqx-patch-1 branch June 1, 2021 05:43
@tvernum tvernum added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes labels Jun 11, 2021
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jun 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@tvernum
Copy link
Contributor

tvernum commented Jun 11, 2021

Hi @zethsqx

In the future if you want to make changes to the Elasticsearch repo, can you wait for someone on the Elasticsearch team to review the changes before you commit.

Our policy is that no changes are merged without being reviewed first, but also there are steps we need to go through to make sure the change is applied to every version of the docs, which may not be obvious to people outside the team.

@zethsqx
Copy link
Contributor Author

zethsqx commented Jun 11, 2021

Understood, apologies on that

Hi @zethsqx

In the future if you want to make changes to the Elasticsearch repo, can you wait for someone on the Elasticsearch team to review the changes before you commit.

Our policy is that no changes are merged without being reviewed first, but also there are steps we need to go through to make sure the change is applied to every version of the docs, which may not be obvious to people outside the team.

jrodewig added a commit that referenced this pull request Jun 14, 2021
Missing comma in example

Co-authored-by: Ming Liang <42666128+zethsqx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.13.2 v7.14.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants