Removing useless methods and method parameters from ObjectMapper.java and TypeParsers.java #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfontes Merged, thanks! |
|
@jpountz Just a note. It breaks plugins as method public static void parseMultiField(AbstractFieldMapper.Builder builder, String name, Map<String, Object> node, Mapper.TypeParser.ParserContext parserContext, String propName, Object propNode)has been changed to: public static void parseMultiField(AbstractFieldMapper.Builder builder, String name, Mapper.TypeParser.ParserContext parserContext, String propName, Object propNode)Without keeping the old method and deprecate it in 1.4.0. Not a big deal but some mapper plugin authors could hit this. (Mapper attachments is one of them :) ) |
dadoonet
added a commit
to elastic/elasticsearch-mapper-attachments
that referenced
this pull request
Sep 4, 2014
As seen with elastic/elasticsearch#7474, we need to update mapper attachment plugin with this new signature. Closes #83. (cherry picked from commit 20ee711)
dadoonet
added a commit
to elastic/elasticsearch-mapper-attachments
that referenced
this pull request
Sep 4, 2014
As seen with elastic/elasticsearch#7474, we need to update mapper attachment plugin with this new signature. Closes #83.
areek
pushed a commit
that referenced
this pull request
Sep 8, 2014
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #7271 I found some methods that were not being used (I searched for the names too, to see if I could find any reflective calls) and some method parameters too.
To make it easier to merge #7271 I am submitting this as a side Pull request.
I've ran all tests and they OK!
Thanks