-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rpm build to add sha256 payload and file digest #75731
Conversation
To verify the change this PR introduces you can run ./gradlew :distribution:packages:buildRpm and then verify the rpm: by running rpm --checksig -v distribution/packages/rpm/build/distributions/elasticsearch-8.0.0-SNAPSHOT-x86_64.rpm distribution/packages/rpm/build/distributions/elasticsearch-8.0.0-SNAPSHOT-x86_64.rpm which should result in:
|
I have tested this on a centos 8 fips enabled machine: installing unsupported 7.13.3 elasticsearch package resulted in the following problems:
With the RPMs created using this PR we get:
I tested this with a local created RPM which was not signed as done in our release process but seems that is not required. In an initial fix where I just added the sha256 payload digest seem not to be enough and changing the file digest from md5 to sha256 seems also necessary as otherwise we see this error:
|
Pinging @elastic/es-delivery (Team:Delivery) |
This is a follow up on elastic#75569 and should fix installation problems in FIPS enabled environments.
53e28f3
to
dd9acb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also built and verified the RPM.
This is a follow up on elastic#75569 and should fix installation problems in FIPS enabled environments.
This is a follow up on elastic#75569 and should fix installation problems in FIPS enabled environments.
This is a follow up on #75569 and should fix installation problems in FIPS enabled environments.
I have updated the PR on redline to add sha256 payload and file digests
(see craigwblake/redline#157 for details). This should enable the installation of our RPM packages in FIPS enabled environments.
The patch provided to redline adds some overhead to the rpm packaging as we need to run through the payload twice to calculate the payload digest first. I haven't found a more elegant way to do this at the moment as this would required way more rework in redline IMO but it should unblock us from not being installable on FIPS environments.