Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Allow first empty line for msearch #75886

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[Rest Api Compatibility] Allow first empty line for msearch #75886

merged 1 commit into from
Aug 5, 2021
+99 −4

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 30, 2021 •
edited
Loading

The support for this lenient behaviour was removed in #41011
however since this is a change that affects a request shape it should
still be available to use it in rest api compatibility

relates #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Allow first empty line for msearch
e9e1f35 
The support for this buggy behaviour was removed in elastic#41011
however since this is a change that affects a request shape it should
still be available to use it in rest api compatibility

relates elastic#51816
@pgomulka pgomulka self-assigned this Jul 30, 2021
@pgomulka pgomulka added the :Core/Infra/REST API REST infrastructure and utilities label Jul 30, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka added the :Search/Search Search-related issues that do not fall into other categories label Jul 30, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 76135bf into elastic:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@javanna javanna Awaiting requested review from javanna

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities :Search/Search Search-related issues that do not fall into other categories Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgomulka @elasticmachine @romseygeek @jakelandis @elasticsearchmachine