Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Aug 11, 2021

The javadoc generation for painless api classes was broken by a recent
commit. This commit fixes it by correct the classpath used to run the
javadoc task. Additionally, the task is added to check to ensure it
runs with CI.

closes #76373

The javadoc generation for painless api classes was broken by a recent
commit. This commit fixes it by correct the classpath used to run the
javadoc task. Additionally, the task is added to `check` to ensure it
runs with CI.

closes elastic#76373
@rjernst rjernst added >non-issue :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.15.0 labels Aug 11, 2021
@rjernst rjernst requested a review from jdconrad August 11, 2021 19:56
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Aug 11, 2021
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst
Copy link
Member Author

rjernst commented Aug 11, 2021

@elasticmachine test this

@elasticsearchmachine elasticsearchmachine merged commit dfcb341 into elastic:master Aug 11, 2021
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Aug 11, 2021
The javadoc generation for painless api classes was broken by a recent
commit. This commit fixes it by correct the classpath used to run the
javadoc task. Additionally, the task is added to `check` to ensure it
runs with CI.

closes elastic#76373
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

@rjernst rjernst deleted the painless/fix_javadoc_gen branch August 11, 2021 23:09
elasticsearchmachine pushed a commit that referenced this pull request Aug 11, 2021
The javadoc generation for painless api classes was broken by a recent
commit. This commit fixes it by correct the classpath used to run the
javadoc task. Additionally, the task is added to `check` to ensure it
runs with CI.

closes #76373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >non-issue Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eclipse import broken

5 participants