Skip to content

Conversation

@costin
Copy link
Member

@costin costin commented Aug 11, 2021

Backports the following commits to 7.x:

* QL: Upgrade ANTLR and move it into QL

Following elastic#76288, upgrade ANTLR library to benefit from the various
improvements made in most recent releases in particular better
performance and error messages.

Looking at the changelog, since version 4.7.2 most changes in ANTLR seem
to have occurred in non-Java targets however this commit upgrades to
ANTLR 4.9.2 to benefit from the dependency updates (such as
StringTemplate).

Additionally move the library into QL to consolidate its use across QL
projects.

Relates elastic#74448
Fix elastic#76354

* Fix matching on error message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@costin costin force-pushed the backport/7.x/pr-76358 branch from 5344222 to df64577 Compare August 11, 2021 20:32
@costin costin added :Analytics/SQL SQL querying :Analytics/EQL EQL querying labels Aug 11, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Aug 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@costin
Copy link
Member Author

costin commented Aug 11, 2021

@elasticmachine update branch

@costin costin added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed >enhancement :Analytics/SQL SQL querying :Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Aug 11, 2021
@costin costin self-assigned this Aug 11, 2021
@costin
Copy link
Member Author

costin commented Aug 12, 2021

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 38b00c8 into elastic:7.x Aug 12, 2021
@costin costin deleted the backport/7.x/pr-76358 branch August 12, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants