Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation checks for geo_shape parameters #76627

Merged

Conversation

masseyke
Copy link
Member

The following properties have been removed from the geo_shape data type in 8.0: "strategy", "tree", "tree_levels", "precision", "distance_error_pct", "points_only". This PR adds a deprecation info API check for indexes and templates that have any of these properties in their mappings. Relates to #42404 and #70850.

@masseyke masseyke linked an issue Aug 17, 2021 that may be closed by this pull request
80 tasks
@masseyke masseyke requested a review from jbaiera August 20, 2021 18:03
@masseyke
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but things look good

@jbaiera jbaiera self-requested a review August 31, 2021 19:38
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those changes

@masseyke masseyke merged commit 121bd05 into elastic:7.x Sep 1, 2021
@masseyke masseyke deleted the feature/geo_shape_parameter_deprecation branch September 1, 2021 21:00
masseyke added a commit that referenced this pull request Sep 7, 2021
Fixed wording in the details message for the deprecation info API for geo_shape fields.
Relates #42404 #76627
@danhermann danhermann added :Analytics/Geo Indexing, search aggregations of geo points and shapes >deprecation labels Dec 3, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >deprecation Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Deprecation Info API checks for 8.0
6 participants