Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Monitoring ingest pipelines #77459

Merged
merged 9 commits into from
Sep 28, 2021

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Sep 8, 2021

Monitoring installs a number of ingest pipelines which have been historically used to upgrade documents when mappings and document structures change between versions. Since there aren't any changes to the document format, nor will there be by the time the format is completely retired, we can comfortably remove these pipelines.

Relates #50770

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@jbaiera
Copy link
Member Author

jbaiera commented Sep 13, 2021

@elasticmachine update branch

@jbaiera
Copy link
Member Author

jbaiera commented Sep 14, 2021

@elasticmachine run elasticsearch-ci/part-2

@jbaiera
Copy link
Member Author

jbaiera commented Sep 14, 2021

Digging into these test failures. From the looks of things, the order of the pipelines in the expected error message is different now. I do not understand what might have caused that yet.

@jbaiera jbaiera requested a review from lcawl September 14, 2021 21:00
@jbaiera
Copy link
Member Author

jbaiera commented Sep 14, 2021

Added @lcawl as reviewer since you were suggested for the deprecation PR, and because this one also has docs changes

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaiera
Copy link
Member Author

jbaiera commented Sep 16, 2021

@elasticmachine update branch

@jbaiera jbaiera merged commit eafbd33 into elastic:master Sep 28, 2021
@jbaiera jbaiera deleted the monitoring-remove-ingest-pipelines branch September 28, 2021 20:10
@jbaiera
Copy link
Member Author

jbaiera commented Oct 6, 2021

Changing to the deprecation label since we have re-added the removed settings in 8.0 to allow for a longer deprecation cycle. The settings will not break 8.0 nodes on start up, but it will not have any functionality tied to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants