Remove default maxmind geoip databases from distribution #78362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
geoip_remove_default_databases
branch
3 times, most recently
from
197b5a5 to
6e1c111
Compare
adjusted tests. Kept the `geolite2-databases` dependency for tests only. Relates to elastic#68920
…lementation. When DatabaseRegistry detects that databases are available then all geoip processor that failed loading will be reloaded.
martijnvg
force-pushed
the
geoip_remove_default_databases
branch
from
6e1c111 to
b44dcb7
Compare
martijnvg
added
:Data Management/Ingest Node
…compatability tests because these assume default database and not fixture.
…n test clusters is false.
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
martijnvg
changed the title
probakowski
approved these changes
Oct 13, 2021
| /** | ||
| * Keeps track of the databases locally available to a node: | ||
| * 1) Default databases shipped with the default distribution via ingest-geoip module | ||
| * 2) User provided databases from the ES_HOME/config/ingest-geoip directory. This directory is monitored | ||
| * 1) User provided databases from the ES_HOME/config/ingest-geoip directory. This directory is monitored |
There was a problem hiding this comment.
- doesn't make sense here as we have single point
Also I will rename this class to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geolite2-databasesdependency for most of the unit tests only.fallback_to_default_databasesparameter on geoip processor a noop and emit deprecation warning upon using it.tagstring array field, which contains a string_geoip_database_unavailable_{database_name}for each missing database in a pipeline.Relates to #68920