-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove multiple paths from ShardPath (#72713)" #78485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08a89c8.
rjernst
added
>non-issue
:Core/Infra/Core
Core issues without another label
v8.0.0
labels
Sep 29, 2021
Pinging @elastic/es-core-infra (Team:Core/Infra) |
henningandersen
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
rjernst
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Sep 29, 2021
17 tasks
grcevski
pushed a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 12, 2021
Add few more tests to ShardPathTests to cover the usage with multiple data paths. Relates to elastic#78485
grcevski
added a commit
that referenced
this pull request
Oct 13, 2021
Add few more tests to ShardPathTests to cover the usage with multiple data paths. Relates to #78485
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 13, 2021
Add few more tests to ShardPathTests to cover the usage with multiple data paths. Relates to elastic#78485
grcevski
added a commit
that referenced
this pull request
Oct 13, 2021
Add few more tests to ShardPathTests to cover the usage with multiple data paths. Relates to #78485
grcevski
added a commit
to grcevski/elasticsearch
that referenced
this pull request
Oct 13, 2021
Add few more tests to ShardPathTests to cover the usage with multiple data paths. Relates to elastic#78485
grcevski
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Core
Core issues without another label
>non-issue
Team:Core/Infra
Meta label for core/infra team
v8.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 08a89c8.
The revert was clean, no merge conflicts.
relates #71205