Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test for flattened type in top_metrics.yml #78960

Merged
merged 1 commit into from
Oct 18, 2021
Merged

added test for flattened type in top_metrics.yml #78960

merged 1 commit into from
Oct 18, 2021

Conversation

nilanshu96
Copy link
Contributor

@nilanshu96 nilanshu96 commented Oct 12, 2021 •
edited
Loading

Resolves issue 70108

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • If submitting code, have you built your formula locally prior to submission with gradle check? y
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added v8.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 12, 2021
@imotov
Copy link
Contributor

imotov commented Oct 12, 2021

@elasticmachine test this please

@imotov imotov requested a review from nik9000 October 12, 2021 13:51
@imotov imotov added the :Analytics/Aggregations Aggregations label Oct 12, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

nik9000
nik9000 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member

nik9000 commented Oct 12, 2021

Looks good. Sorry I hadn't noticed your pings earlier.

@nilanshu96
Copy link
Contributor Author

@nik9000 no problem. Also thanks for reviewing. I was only hoping my first code contribution here looks alright.

@nik9000 nik9000 merged commit 6895511 into elastic:master Oct 18, 2021
@nik9000
Copy link
Member

nik9000 commented Oct 18, 2021

I'll manually backport this one to 7.x later today.

@nik9000
Copy link
Member

nik9000 commented Oct 18, 2021

I don think the bot can handle external contributors, sadly. It needs an authentication path that doesn't work.

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 18, 2021
@weizijun
Merge branch 'upstream/master' into reuse-date-stream-timestamp
4933482 
* upstream/master:
  Changing test keytab to use aes256-cts-hmac-sha1-96 instead of des3-cbc-sha1-kd (elastic#78703)
  Add support for configuring HNSW parameters (elastic#79193)
  Deprecate resolution loss on date field (elastic#78921)
  Add Optional to Configure bind user (elastic#78303)
  Adapt BWC after backporting elastic#78765 (elastic#79350)
  [DOCS] Add deprecation notice for reset password tool (elastic#78793)
  added test for flattened type in top_metrics.yml (elastic#78960)
  [DOCS] Fixes indentation issue in GET trained models API docs. (elastic#79347)
  Fix parsing of PBES2 encrypted PKCS#8 keys (elastic#78904)
  Mute testReindex (elastic#79343)
  Node level can match action (elastic#78765)
  Fix duplicate license header in source files (elastic#79236)
  AllowAll for indicesAccessControl (elastic#78498)
  Better logging and internal user handling for operator privileges (elastic#79331)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MappingParser.java
nik9000 pushed a commit to nik9000/elasticsearch that referenced this pull request Oct 18, 2021
@nilanshu96 @nik9000
added test for flattened type in top_metrics.yml (elastic#78960)
9b6c40e
@nik9000
Copy link
Member

nik9000 commented Oct 18, 2021

I'll manually backport this one to 7.x later today.

#79368

elasticsearchmachine pushed a commit that referenced this pull request Oct 18, 2021
@nik9000 @nilanshu96
added test for flattened type in top_metrics.yml (#78960) (#79368)
171ae21 
Co-authored-by: Nilanshu V Rajmane <rajmanenilanshu@gmail.com>
@nik9000 nik9000 mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nilanshu96 @imotov @elasticmachine @nik9000 @jakelandis @elasticsearchmachine