Update edgengram-tokenizer.asciidoc #79577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the originally used example of "snapped" does not apply to this section, since we are talking about EDGE ngrams... "snapped" does not include "app" as an EDGE. I replaced the term with "approximate" as a valid example.
|
💚 CLA has been signed |
elasticsearchmachine
added
v7.15.2
external-contributor
cbuescher
reviewed
Oct 25, 2021
docs/reference/analysis/tokenizers/edgengram-tokenizer.asciidoc
Outdated
Show resolved
Hide resolved
cbuescher
approved these changes
Oct 25, 2021
What browser are you using? Did you try a different browser, maybe Chrome if you are usually using Firefox etc...? Sometimes this helps with missing pop-ups etc... |
ok, this time it worked :) |
|
@elasticsearchmachine ok to test |
|
@nexusalf thanks fpr signing, would you mind commiting the suggested line break or mind if I do so before merging? |
Co-authored-by: Christoph Büscher <cbuescher@posteo.de>
i hope i did everything correctly, i am not very familiar with using github ;) |
|
Pinging @elastic/es-docs (Team:Docs) |
|
@nexusalf all good and thanks for the change |
cbuescher
pushed a commit
that referenced
this pull request
Oct 26, 2021
The original example of "snapped" does not apply to this section since it is talking about edge ngrams. The change replaces the term with "approximate" as a valid example.
cbuescher
pushed a commit
that referenced
this pull request
Oct 26, 2021
The original example of "snapped" does not apply to this section since it is talking about edge ngrams. The change replaces the term with "approximate" as a valid example.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 26, 2021
* upstream/master: (209 commits) Enforce license expiration (elastic#79671) TSDB: Automatically add timestamp mapper (elastic#79136) [DOCS] `_id` is required for bulk API's `update` action (elastic#79774) EQL: Add optional fields and limit joining keys on non-null values only (elastic#79677) [DOCS] Document range enrich policy (elastic#79607) [DOCS] Fix typos in 8.0 security migration (elastic#79802) Allow listing older repositories (elastic#78244) [ML] track inference model feature usage per node (elastic#79752) Remove IncrementalClusterStateWriter & related code (elastic#79738) Reuse previous indices lookup when possible (elastic#79004) Reduce merging in PersistedClusterStateService (elastic#79793) SQL: Adjust JDBC docs to use milliseconds for timeouts (elastic#79628) Remove endpoint for freezing indices (elastic#78918) [ML] add timeout parameter for DELETE trained_models API (elastic#79739) [ML] wait for .ml-state-write alias to be readable (elastic#79731) [Docs] Update edgengram-tokenizer.asciidoc (elastic#79577) [Test][Transform] fix UpdateTransformActionRequestTests failure (elastic#79787) Limit CS Update Task Description Size (elastic#79443) Apply the reader wrapper on can_match source (elastic#78988) [DOCS] Adds new transform limitation item and a note to the tutorial (elastic#79479) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexMode.java # server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
The original example of "snapped" does not apply to this section since it is talking about edge ngrams. The change replaces the term with "approximate" as a valid example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(i read the comments down below regarding singing up for contributors, but the widget doesn't seem to work -- after clicking on "begin signing" nothing happens. perhaps this can go without agreement as this is just a minor documentation text change, not a code commitment -- i am not a developer anyway, i use this account only to update documentation texts that i see could use some update ;) )
the originally used example of "snapped" does not apply to this section, since we are talking about EDGE ngrams... "snapped" does not include "app" as an EDGE (in this example, the edge would be "sna"). I replaced the term with "approximate" as a valid example.
gradle check?